Issue 90072 - Undo - Long strings have to be cut <start>...<end>
Summary: Undo - Long strings have to be cut <start>...<end>
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: ui (show other issues)
Version: DEV300m13
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: eric.savary
QA Contact: issues@sw
URL: http://specs.openoffice.org/writer/un...
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-28 13:17 UTC by eric.savary
Modified: 2013-08-07 14:43 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Shortening of additional information (1.39 KB, patch)
2008-11-06 09:58 UTC, dtardon 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description eric.savary 2008-05-28 13:17:04 UTC 
Follow up to issue 85833.
- insert the dummy text
- Ctrl+A
- Del
-> the undo menu shows the deleted paragraph cut after 80 characters.

According to the undo specification,

http://specs.openoffice.org/writer/undo/Undo_GeneralWriter.sxw
See:"6.2 More verbosity in undo stack"

longs strings have to be cut this way: <20 characters from begin of the
paragraph>...<20 characters to the end of the paragraph>
Comment 1 andreas.martens 2008-05-29 07:32:35 UTC 
Retarget to 3.x
Comment 2 dtardon 2008-11-06 09:51:13 UTC 
->es: I think your interpretation of maximal length for the additional
information is wrong. The undo spec says: "To prevent a too large menu or popup
at most twenty characters of additional information will be given. If the
additional information is longer than twenty characters it will be shortened,
i.e. inner characters will be removed to shorten the information string to
twenty characters. The missing characters are indicated by STR_LDOTS."

I'm attaching an alternative solution, which, I think, is better conforming to
that requirement.
Comment 3 dtardon 2008-11-06 09:58:25 UTC 
Created attachment 57735 [details]
Shortening of additional information
Comment 4 caolanm 2008-12-16 23:22:07 UTC 
Can we have a quick look at this for a 3.1 target. Not a problem if the decision
is then a later target.
Comment 5 andreas.martens 2008-12-17 07:39:24 UTC 
ama: I think I will be able to apply this patch in time for OOo3.1. I don't
promise it but it should be doable ;-)
Comment 6 eric.savary 2008-12-19 14:08:51 UTC 
@dtardon: you're perfectly right! I'm a little bit wrong! ;)

@all: adding this issue to CWS swundo4 (3.1) for now. If this is a problem, we
may discuss this next year (2009) when everybody's back from vacation.
Comment 7 eric.savary 2008-12-19 14:21:15 UTC 
Sorry (really need vacation!)!
swundo4 is an UI-Change CWS for 3.2.
Resetting issue back to a CWS-less state.
Comment 8 andreas.martens 2009-01-09 13:48:21 UTC 
->dtardon:
Thank you for your patch. I will apply it to my CWS sw31bf02.
It works like a charm.
Comment 9 andreas.martens 2009-01-23 13:02:43 UTC 
Ready for QA.
Comment 10 eric.savary 2009-02-02 11:26:31 UTC 
Verified in CWS sw30bf02
Comment 11 caolanm 2009-02-24 14:22:08 UTC 
seen in OOO310_m2 and DEV300_m42