Issue 98385 - Download box always redirects to a build with JRE, even when it doesn't exist
Summary: Download box always redirects to a build with JRE, even when it doesn't exist
Status: CLOSED FIXED
Alias: None
Product: QA
Classification: Unclassified
Component: www (show other issues)
Version: current
Hardware: All All
: P3 Trivial
Target Milestone: ---
Assignee: Joost Andrae
QA Contact: issues@qa
URL: http://download.openoffice.org/downlo...
Keywords:
Depends on:
Blocks: 97532
  Show dependency tree
 
Reported: 2009-01-23 07:40 UTC by rq
Modified: 2009-02-17 13:36 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
A possible patch (11.43 KB, patch)
2009-01-23 08:22 UTC, rq 		no flags Details | Diff
Patch with an appropriate comment in the header (11.56 KB, patch)
2009-01-23 08:32 UTC, rq 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description rq 2009-01-23 07:40:36 UTC 
http://www.openoffice.org and http://download.openoffice.org both have a green
download OOo box. However, that box doesn't work for Lithuanian localization
(and perhaps some others that don't have JRE builds too).

Please fix it ASAP. Thanks! :)
Comment 1 rq 2009-01-23 08:22:29 UTC 
Created attachment 59609 [details]
A possible patch
Comment 2 rq 2009-01-23 08:32:32 UTC 
Created attachment 59611 [details]
Patch with an appropriate comment in the header
Comment 3 rq 2009-01-23 08:37:54 UTC 
OK, here's the patch (use the second one as I forgot to add an appropriate
comment in the first one).

What I did is introduced a new member to the arrays in languages[], which
indicates whether builds with JRE are available or not. I have set "y" for all
languages except lt since I don't know which ones should carry "n".

I have tested the patch locally, and it works well for me by creating an
appropriate link to Lithuanian builds. I haven't tried with other languages though.

Please fix the problem as soon as possible, because it's already been two weeks
since Lithuanians started seeing a download box that doesn't actually work... :)
Comment 4 rq 2009-01-23 08:43:33 UTC 
I just tested the patch with browser locale set to "en" and "ru", and both work
very well. Thus I believe the patch to be safe.
Comment 5 Joost Andrae 2009-01-23 16:05:23 UTC 
ja->fma: Frank, could you please care about this ? download.js will get it's
next update on next tuesday due to 3.0.1 release and it would be good to have
the changes included until then.
Comment 6 hans_werner67 2009-01-26 09:10:09 UTC 
Verifing patch, thanks to rq!!!
Comment 7 rq 2009-01-26 09:18:42 UTC 
By the way, the comment for languages array says that the language name should
be in English, but I just noticed that it's in Portuguese for Portuguese builds.
Frank, you may want to either fix the comment or the array.
Comment 8 hans_werner67 2009-01-26 09:40:42 UTC 
Patch included in download.js. Please verify.

Big thanks to rq!
Cheers,
Frank
Comment 9 hans_werner67 2009-01-26 09:41:15 UTC 
.
Comment 10 Joost Andrae 2009-01-26 09:46:39 UTC 
thanks
Comment 11 rq 2009-01-26 09:52:32 UTC 
Yoohoo! Thanks a lot! :)
Comment 12 Joost Andrae 2009-02-17 13:36:53 UTC 
closing issue