This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 213266 - Some actions without icon shown in Customize Toolbars
Summary: Some actions without icon shown in Customize Toolbars
Status: STARTED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 7.2
Hardware: All All
: P3 normal (vote)
Assignee: Stanislav Aubrecht
URL:
Keywords:
: 233577 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-05-31 02:15 UTC by hantsy
Modified: 2013-07-29 13:55 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
action display name (22.74 KB, image/png)
2012-05-31 02:16 UTC, hantsy 		Details
action display name (47.97 KB, image/png)
2012-05-31 02:34 UTC, hantsy 		Details
action display name3 (43.77 KB, image/png)
2012-05-31 02:35 UTC, hantsy 		Details
Failed attempt to reproduce in unit test (1.16 KB, patch)
2012-06-01 16:53 UTC, Jesse Glick 		Details | Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hantsy 2012-05-31 02:15:45 UTC 
attach an image about this.
I used NB7.2 zip archived.
Comment 1 hantsy 2012-05-31 02:16:41 UTC 
Created attachment 120094 [details]
action display name
Comment 2 hantsy 2012-05-31 02:34:43 UTC 
Created attachment 120096 [details]
action display name
Comment 3 hantsy 2012-05-31 02:35:39 UTC 
Created attachment 120097 [details]
action display name3
Comment 4 Jesse Glick 2012-06-01 16:52:24 UTC 
(In reply to comment #1)
> Created attachment 120094 [details]
> action display name

Mostly apisupport-related actions, though one freeform as well, and many others in Debug, Edit, and Form categories. None of these actions specify an icon, so ConfigureToolbarPanel.ActionIconDataFilter is supposed to be ignoring them, yet it is not. Note that if you e.g. open an NBM project and post its context menu, the corresponding items are correctly hidden the next time you open the customizer. It seems the return value from ActionIconDataFilter is indeed correct, so something is wrong with the node hierarchy.

(In reply to comment #2)
> Created attachment 120096 [details]
> action display name

Unrelated, file in profiler component.

(In reply to comment #3)
> Created attachment 120097 [details]
> action display name3

Unrelated, file in CND.
Comment 5 Jesse Glick 2012-06-01 16:53:40 UTC 
Created attachment 120220 [details]
Failed attempt to reproduce in unit test

This test passes, though it seems a similar situation in the live IDE fails at least under certain circumstances.
Comment 6 Jesse Glick 2012-06-01 17:04:07 UTC 
Committed the test and some diagnostics as core-main #c1a2b77d5548. I am starting to suspect a bug in FolderNode: acceptDataObject is consistently returning what I think are correct results, yet the nodes are _sometimes_ displayed in the tree anyway (other times they are correctly hidden).
Comment 7 Stanislav Aubrecht 2012-06-04 10:32:35 UTC 
Reporter, is this a random event or is the bug reproducible every time?
Comment 8 Jesse Glick 2012-06-04 22:15:02 UTC 
I am able to reproduce it.
Comment 9 Quality Engineering 2012-06-05 06:02:41 UTC 
Integrated into 'main-golden', will be available in build *201206050001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/c1a2b77d5548
User: Jesse Glick <jglick@netbeans.org>
Log: #213266 diagnostics.
Comment 10 Stanislav Aubrecht 2013-07-29 13:55:14 UTC 
*** Bug 233577 has been marked as a duplicate of this bug. ***