Apache OpenOffice (AOO) Bugzilla – Issue 86924
some icons not updated on a icon theme change
Last modified: 2008-06-02 11:12:32 UTC
Some icons don't change on an icon theme change until a restart. a) the icons in the vanilla file picker b) the icons in the first drop down list on the icon menu bar, i.e. the one that says "text document", "presentation" etc. To reproduce, start OOo, drop down the list of b) and do a file open for a) and then change the icon theme to high contrast and revisit them. Patch attached to fix
Created attachment 52030 [details] patch to fix
not certain that the mnuitem fix is needed, but its the same pattern as the tbxctrl one which was needed
Hi I'm guessing your patch will fix: Issue 60787 ?... There area also some related problems (just for info): Message box images not updated - Issue 60788 Quickstarter 'My Documents' with wrong icons - Issue 60789 Cheers Andrew
Wasn't aware of the other issues, but yes the "new" dropdown in issue 60787 is definitely fixed by this patch, so 60787 looks like it can be made a duplicate of this (duping towards the issue with a patch). I don't know about the other two though, that'd need to be checked with this patch in place to see if they are using the same underlying classes touched here and will magically get fixed, or if there are some other remaining locations that need to drop their cached images on a theme change.
Thanks for the patch! Carsten, please take over.
*** Issue 60787 has been marked as a duplicate of this issue. ***
cd: Thanks for the patch Caolan. cd: Changed platform to "All" as this patch is not platform dependent. cd->pb: Please take over. I am not able to check the patch carefully as I will be in vacation from tomorrow on. I just took a quick look and found no problems. The patch looks good to me.
Please don't forget to check the status of the other mentioned issues here after the patch has been applied.
pb: I take over.
pb: patch integrated in cws fwk86: Files changed: /svtools/source/misc/imagemgr.cxx 1.50.30.1 /sfx2/inc/sfx2/mnuitem.hxx 1.2.282.1 /sfx2/inc/sfx2/tbxctrl.hxx 1.2.282.1 /sfx2/source/menu/mnuitem.cxx 1.21.82.1 /sfx2/source/toolbox/tbxitem.cxx 1.67.216.1
pb: issue 60787 and issue 60789 are fixed with this patch but not issue 60788.
pb -> tm: please verify. Thx.
pb -> tm: this patch doesn't fix that the images of the submenu of the "New" menu entry don't change but it fixes that images of the menu of the "New" toolbar button change. The "New" menu is another implementation.
checked and verified in cws fwk86 -> OK
seen in DEV300_m13
*** Issue 88249 has been marked as a duplicate of this issue. ***