Issue 88406 - Tracked changes: already existing text is marked as inserted, too - integrated
Summary: Tracked changes: already existing text is marked as inserted, too - integrated
Alias: None
Product: Writer
Classification: Application
Component: editing (show other issues)
Version: OOo 2.4.0
Hardware: All All
: P2 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
Keywords: regression
: 85708 88760 (view as issue list)
Depends on:
Blocks: 87736 88258
  Show dependency tree
Reported: 2008-04-17 18:52 UTC by cno
Modified: 2013-08-07 14:43 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

document to demonstrate bug (12.01 KB, application/vnd.oasis.opendocument.text)
2008-04-17 18:55 UTC, cno
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description cno 2008-04-17 18:52:45 UTC

When tracking changes, already existing text is marked.
Has to do with some circumstances, I guess, but I can reproduce.

1- Open sample document;
2- Enable track changes;
3- Put cursor at end of paragraph with outline number 1;
4- type some bla bla => marked
5- Now put cursor at end of paragraph with outline number 2;
6- again type some bla bla => (nearly) whole line is marked
Comment 1 cno 2008-04-17 18:55:23 UTC
Created attachment 52972 [details]
document to demonstrate bug
Comment 2 cno 2008-04-17 19:11:49 UTC
Also broken in 300m5
Comment 3 michael.ruess 2008-04-18 09:32:13 UTC
MRU->AMA: see attached document, add text at the end of paragraph numbered 1.
Then add text at the following paragraph -> the whole line is marked as inserted.
When doing this vice versa, whole pargraph 2. is marked as inserted.
Was good in OO 2.3.1.
Comment 4 uwe.luebbers 2008-04-18 14:26:56 UTC
This issue has the wrong target to be a 3.0 beta blocker, beside that it could be a 
question if it is serious enough to block a BETA! (or 2.4.1).

Comment 5 andreas.martens 2008-04-18 15:13:46 UTC
ama: Some details...
It's easy and without risk to fix. There has been a small local code change
(maybe for warning free code or whatever) which causes this issue. To fix this I
only need to (re-)change one character in our source!

Here is the bug description:
If change tracking is active,
- you change something at the end of a paragraph
- do another change in the middle (or end) of the next paragraph within the next
=> All characters of the second paragraph before your change will be "redlined",
This happens only if both changes happens in the same second because only in
this case the algorithm joins change tracks.

Resume: Maybe not the most important issue but the fix is easy and has very low
Comment 6 cno 2008-04-18 18:36:09 UTC
Hi Andreas,
The 'one second' time frame does not count on my side :-(
Comment 7 andreas.martens 2008-04-21 10:26:36 UTC
You have to wait for the "right" second, the last second of a minute ;-)
You are right, the bug occurs when these two changes have been done within the
same minute (absolute, not relative, so sometimes you have to wait one second,
sometimes 59 seconds). 
Comment 8 andreas.martens 2008-04-21 10:29:51 UTC
Fixed in CWS sw30beta01.
Comment 9 andreas.martens 2008-04-21 10:40:22 UTC
Set to fixed.
Comment 10 andreas.martens 2008-04-21 10:50:45 UTC
Fixed in CWS sw241bf01 as well.
Comment 11 andreas.martens 2008-04-21 10:56:21 UTC
Ready for QA in CWS sw30beta01.
Comment 12 h.ilter 2008-04-25 11:54:34 UTC
Verified with cws sw30beta01 = ok
Comment 13 michael.ruess 2008-04-28 10:14:14 UTC
*** Issue 88760 has been marked as a duplicate of this issue. ***
Comment 14 uwe.luebbers 2008-04-28 12:03:32 UTC
added "approved" to the title, because it will be easier to work with the 2.4.1 meta issue 
during release status meetings.
Comment 15 andreas.martens 2008-04-28 14:05:44 UTC
*** Issue 85708 has been marked as a duplicate of this issue. ***
Comment 16 fredrik.haegg 2008-04-28 14:39:23 UTC
Automation possible.
Comment 17 fredrik.haegg 2008-04-28 14:45:18 UTC
Automation possible.
Comment 18 uwe.luebbers 2008-04-29 16:58:03 UTC
added "integrated 3.0" to the title, to make it easier to work with the meta issue
Comment 19 michael.ruess 2008-05-02 11:13:40 UTC
Also verified in CWS sw241bf01 for OO 2.4.1 branch.
Comment 20 michael.ruess 2008-06-09 14:46:20 UTC
Checked fix in DEV300m17.
Comment 21 uwe.luebbers 2008-06-25 15:51:57 UTC
adjusted title